cse15l-lab-reports
Testing Snippet 1,2,3
Important Links
Reviewed MarkdownParse Repository
Snippet 1
Expected Output for getLinks():
[`google.com, google.com, ucsd.edu]
JUnit Test used on both versions of MarkdownParse
JUnit Test My version of MarkdownParse output:
JUnit Test Reviewed version of MarkdownParse output:
Code fix: I think there is a code fix that is less than 10 lines. MarkdownParse could skip over code that is between two backticks or between one backtick and the next line by setting the currentIndex to the index after the second parenthesis or the next line’s starting index and using continue to iterate through the loop. However this is not the case when backticks are within a links () or [] so we could use an if statment to check that the ticks are not between nextOpenBracket and nextClosedBracket or openParen and closedParen.
Snippet 2
Expected Output for getLinks():
[b.com, a.com(()), example.com]
JUnit Test used on both versions of MarkdownParse
JUnit Test My version of MarkdownParse output:
JUnit Test Reviewed version of MarkdownParse output:
Code Fix: I think there is a code fix that is less than 10 lines. Mardown parse could ignore inner parenthesis by counting the number of (, ), [, ]. The code would then only look at the outer set of () or [] and treat all the brackets and parenthesis within the brackets as plain text. We could count all the parenthesis or brackets after an open or closed bracket or parenthesis till the next (/[ with a matching set. Then use the outermost set of () or [] as the variables in getLinks().
Snippet 3
Expected Output for getLinks():
[https://ucsd-cse15l-w22.github.io/]
JUnit Test used on both versions of MarkdownParse
JUnit Test My version of MarkdownParse output:
JUnit Test Reviewed version of MarkdownParse output:
Code Fix: I think there is a code fix that is less than 10 lines. Links with spaces between should not be included: [] or () with spaces inbetween text are not valid links. Additionaly links with missing ) should not be included. As MarkdownParse is currently written it will include all code after ( as a part of the link until it finds ). To fix these errors we would need to make the code continue onto the next currentIndex if there are spaces after, [ or (between the next )or]